remove mavis, change on-dock-removed to event dock.removed#1207
Merged
anandkumarpatel merged 5 commits intomasterfrom Dec 7, 2015
Merged
remove mavis, change on-dock-removed to event dock.removed#1207anandkumarpatel merged 5 commits intomasterfrom
anandkumarpatel merged 5 commits intomasterfrom
Conversation
anandkumarpatel
changed the title
Member
|
@anandkumarpatel where/how did you handle problem with swarm scheduling on the wrong dock? |
Member
|
also why did you rename worker from |
Contributor
Author
|
I decided to add code in mavis to wait for key to be removed. It will be a cleaner solution and be what the event 'dock-removed' actually means. |
anandkumarpatel
changed the title
Contributor
Author
|
tested on beta, works like a 🍀 |
Contributor
Author
|
steps for deployment
|
Contributor
There was a problem hiding this comment.
IMHO it's a bit chaotic to use count.inc() and createCount(#, done) in a single test. (Specifying a number of callbacks at initialization and then incrementing it)
Contributor
|
Changes LGTM. I also reviewed associated PR. |
Member
|
code looks good |
Member
|
works on beta! |
anandkumarpatel
pushed a commit
that referenced
this pull request
Dec 7, 2015
remove mavis, change on-dock-removed to event dock.removed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
required changes in other repos
CodeNow/mavis#37
review